Migrate deprecated rollback() call#10367
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jul 8, 2022
Merged
Conversation
losipiuk
approved these changes
Dec 21, 2021
losipiuk
reviewed
Dec 21, 2021
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/RollbackToSnapshotProcedure.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/migrate-deprecated-rollback-call
branch
from
2456622 to
fc0948b
Compare
losipiuk
approved these changes
Dec 21, 2021
alexjo2144
approved these changes
May 13, 2022
Member
|
@findinpath can you resolve the conflicts? |
findinpath
force-pushed
the
findinpath/migrate-deprecated-rollback-call
branch
from
fc0948b to
5b46963
Compare
ebyhr
approved these changes
Jul 8, 2022
Member
|
Merged, thanks! |
ebyhr
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related tests to test the functionality for regressions:
io.trino.plugin.iceberg.TestIcebergOrcConnectorTest#testRollbackSnapshotio.trino.plugin.iceberg.TestIcebergParquetConnectorTest#testRollbackSnapshot