Add reusable smoke test coverage for UPDATE#10355
Merged
findepi merged 1 commit intotrinodb:masterfrom Jan 5, 2022
Merged
Conversation
Currently no connector supports UPDATE in default configuration, but this we should have the test for completeness. In the future, we should have Hive full test run with transactional tables being created by default. Also, Iceberg connector will support UPDATE in its default configuration.
alexjo2144
approved these changes
Dec 20, 2021
ebyhr
approved these changes
Dec 21, 2021
hashhar
approved these changes
Dec 28, 2021
| { | ||
| if (!hasBehavior(SUPPORTS_UPDATE)) { | ||
| // Note this change is a no-op, if actually run | ||
| assertQueryFails("UPDATE nation SET nationkey = nationkey + regionkey WHERE regionkey < 1", "This connector does not support updates"); |
Member
There was a problem hiding this comment.
Can we in future omit such no-op operations in some connectors (hence silently breaking the test)?
Member
There was a problem hiding this comment.
I am not a big fan on testing that on a logically immutable table. If update has bug and actually mutates the table we will get weird test failures in a very unrelated place
Member
Author
There was a problem hiding this comment.
Can we in future omit such no-op operations in some connectors (hence silently breaking the test)?
@hashhar That would require implementing some form of UPDATE support.
If update has bug and actually mutates the table
@losipiuk in the worst case, the test env needs a fix. I don't think it's a big deal.
losipiuk
approved these changes
Dec 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently no connector supports UPDATE in default configuration, but
this we should have the test for completeness.
In the future, we should have Hive full test run with transactional
tables being created by default. Also, Iceberg connector will support
UPDATE in its default configuration.