Use correct configuration property for orc bloom filter#10343
Use correct configuration property for orc bloom filter#10343Praveen2112 merged 4 commits intotrinodb:masterfrom
Conversation
ksobolew
left a comment
There was a problem hiding this comment.
Honestly, that's kind of embarrassing... Difficulty in writing tests for this is only a partial excuse :(
|
The thing is that hive/orc doesn't provide a easier way to expose whether bloom filter is written or not. I'll take a stab at it again to check if it is possible or not. |
4ff453a to
c6f629e
Compare
|
Is it possible to write a queryrunner test where the predicate can result in no data getting read only due to bloom filter (something similar to assertRowGroupPruning in TestParquetPageSkipping). |
349ad2b to
f38b12a
Compare
|
@raunaqmorarka Thanks for the pointers. Last time when I checked with the query runner, the query stats where misleading (maybe I could have a different API). Now I'm able to test if the bloom filter is created or not. Thanks a bunch !! @ksobolew I have added integration tests for it. |
skrzypo987
left a comment
There was a problem hiding this comment.
Do I understand correctly that this never worked?
Yes. |
@Praveen2112 let's consider fixing release notes for 339 |
Writing ORC bloom filter is broken for Hive connector
f38b12a to
0e85567
Compare
|
@findepi Updated release notes. |
Fixes #9792