-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Allow setting per task memory limit #10308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
core/trino-main/src/main/java/io/trino/operator/TaskAllocationValidator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.operator; | ||
|
|
||
| import io.airlift.units.DataSize; | ||
| import io.trino.memory.context.MemoryAllocationValidator; | ||
|
|
||
| import javax.annotation.concurrent.GuardedBy; | ||
| import javax.annotation.concurrent.ThreadSafe; | ||
|
|
||
| import java.util.Comparator; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import static com.google.common.base.Verify.verify; | ||
| import static com.google.common.collect.ImmutableMap.toImmutableMap; | ||
| import static io.airlift.units.DataSize.succinctBytes; | ||
| import static io.trino.ExceededMemoryLimitException.exceededTaskMemoryLimit; | ||
| import static java.lang.String.format; | ||
| import static java.util.Map.Entry.comparingByValue; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| @ThreadSafe | ||
| // Keeps track of per-node memory usage of given task. Single instance is shared by multiple ValidatingLocalMemoryContext instances | ||
| // originating from single ValidatingAggregateContext. | ||
| public class TaskAllocationValidator | ||
losipiuk marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
losipiuk marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| implements MemoryAllocationValidator | ||
| { | ||
| private final long limitBytes; | ||
| @GuardedBy("this") | ||
| private long usedBytes; | ||
| @GuardedBy("this") | ||
| private final Map<String, Long> taggedAllocations = new HashMap<>(); | ||
|
|
||
| public TaskAllocationValidator(DataSize memoryLimit) | ||
| { | ||
| this.limitBytes = requireNonNull(memoryLimit, "memoryLimit is null").toBytes(); | ||
| } | ||
|
|
||
| @Override | ||
| public synchronized void reserveMemory(String allocationTag, long delta) | ||
| { | ||
| if (usedBytes + delta > limitBytes) { | ||
| verify(delta > 0, "exceeded limit with negative delta (%s); usedBytes=%s, limitBytes=%s", delta, usedBytes, limitBytes); | ||
| raiseLimitExceededFailure(allocationTag, delta); | ||
| } | ||
| usedBytes += delta; | ||
| taggedAllocations.merge(allocationTag, delta, Long::sum); | ||
| } | ||
|
|
||
| private synchronized void raiseLimitExceededFailure(String currentAllocationTag, long currentAllocationDelta) | ||
| { | ||
| Map<String, Long> tmpTaggedAllocations = new HashMap<>(taggedAllocations); | ||
| // include current allocation in the output of top-consumers | ||
| tmpTaggedAllocations.merge(currentAllocationTag, currentAllocationDelta, Long::sum); | ||
| String topConsumers = tmpTaggedAllocations.entrySet().stream() | ||
| .sorted(comparingByValue(Comparator.reverseOrder())) | ||
| .limit(3) | ||
| .filter(e -> e.getValue() >= 0) | ||
| .collect(toImmutableMap(Map.Entry::getKey, e -> succinctBytes(e.getValue()))) | ||
| .toString(); | ||
|
|
||
| String additionalInfo = format("Allocated: %s, Delta: %s, Top Consumers: %s", succinctBytes(usedBytes), succinctBytes(currentAllocationDelta), topConsumers); | ||
| throw exceededTaskMemoryLimit(DataSize.succinctBytes(limitBytes), additionalInfo); | ||
| } | ||
|
|
||
| @Override | ||
| public synchronized boolean tryReserveMemory(String allocationTag, long delta) | ||
| { | ||
| if (usedBytes + delta > limitBytes) { | ||
| verify(delta > 0, "exceeded limit with negative delta (%s); usedBytes=%s, limitBytes=%s", delta, usedBytes, limitBytes); | ||
| return false; | ||
sopel39 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| usedBytes += delta; | ||
| return true; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.