NodePartitioningManager code cleanup#10293
Merged
findepi merged 7 commits intotrinodb:masterfrom Dec 16, 2021
Merged
Conversation
It's already checked earlier in the method
Apparently most methods in the class call it `partitioningHandle`, so let's be it.
Replace `Optional.get` with `Optional.orElseThrow` to avoid a warning. Extract variable to maintain readability.
`ConnectorTransactionHandle` should be present.
losipiuk
reviewed
Dec 14, 2021
| ConnectorNodePartitioningProvider partitioningProvider = getPartitioningProvider(catalogName); | ||
| BucketFunction bucketFunction = partitioningProvider.getBucketFunction( | ||
| partitioningHandle.getTransactionHandle().orElse(null), | ||
| partitioningHandle.getTransactionHandle().orElseThrow(() -> new IllegalArgumentException("No transactionHandle for partitioning handle: " + partitioningHandle)), |
Member
There was a problem hiding this comment.
why is transaction handle optional then? What is the case when it is not set? Worth a comment or more descriptive exception message?
Member
Author
There was a problem hiding this comment.
I think the empty transaction handle is for SystemPartitioningHandle (internal use)
losipiuk
approved these changes
Dec 14, 2021
arhimondr
approved these changes
Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.