Describe support of CHAR/VARCHAR predicate pushdown#10110
Merged
hashhar merged 1 commit intotrinodb:masterfrom Dec 3, 2021
Merged
Describe support of CHAR/VARCHAR predicate pushdown#10110hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
hashhar
requested changes
Nov 30, 2021
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
jhlodin
force-pushed
the
jl/pushdown-char-varchar
branch
from
d40b656 to
6443bb0
Compare
mosabua
requested changes
Dec 1, 2021
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
jhlodin
force-pushed
the
jl/pushdown-char-varchar
branch
from
6443bb0 to
fa30aed
Compare
hashhar
reviewed
Dec 1, 2021
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
The fragments might be misleading since they have incomplete information. Maybe they should be titled Predicate pushdown limitations (even then they are incomplete though)?
Looks good % comments.
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
jhlodin
force-pushed
the
jl/pushdown-char-varchar
branch
from
fa30aed to
5544d24
Compare
hashhar
reviewed
Dec 3, 2021
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
A suggestion to rename the fragments since it's not obvious what their contents are it's easy to place the wrong one in the wrong doc.
docs/src/main/sphinx/connector/pushdown-char-varchar-case.fragment
Outdated
Show resolved
Hide resolved
jhlodin
force-pushed
the
jl/pushdown-char-varchar
branch
from
5544d24 to
2db979d
Compare
hashhar
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation for limitations around certain connectors pushing down predicates on CHAR/VARCHAR type columns.