Conversation
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
3 times, most recently
from
9cc081e to
2b0d245
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
3 times, most recently
from
7d06ec5 to
4d94b93
Compare
Member
|
Please close #9054 if this fixes the issue. |
Member
Author
|
I excluded |
hashhar
reviewed
Dec 7, 2021
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Skimmed.
Will take another look. Haven't yet looked at timestamps in detail.
plugin/trino-mariadb/src/main/java/io/trino/plugin/mariadb/MariaDbClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/main/java/io/trino/plugin/mariadb/MariaDbClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/main/java/io/trino/plugin/mariadb/MariaDbClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/main/java/io/trino/plugin/mariadb/MariaDbClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/main/java/io/trino/plugin/mariadb/MariaDbClientModule.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/test/java/io/trino/plugin/mariadb/BaseMariaDbConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/test/java/io/trino/plugin/mariadb/TestMariaDbTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/test/java/io/trino/plugin/mariadb/TestMariaDbTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/test/java/io/trino/plugin/mariadb/TestMariaDbTypeMapping.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
from
4d94b93 to
8269f02
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
4 times, most recently
from
f5702e0 to
fda65d9
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
2 times, most recently
from
82f6118 to
d40a4cc
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
2 times, most recently
from
fdbd402 to
2b1c508
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
2 times, most recently
from
257b9de to
804b49b
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
from
804b49b to
74c519f
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
from
3404bf7 to
e936c47
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
2 times, most recently
from
8ba78ec to
43a549b
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
from
43a549b to
711a6bf
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
from
711a6bf to
1c076b7
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
from
1c076b7 to
bd86dff
Compare
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
from
bd86dff to
b2add0b
Compare
Member
Author
|
Rebased on upstream and fixed the module version in |
hashhar
reviewed
Apr 20, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Looks good, some comments.
Sorry for the very very long delay in reviewing this.
Member
There was a problem hiding this comment.
Should we list aliases together with the original function name? Pre-existing, would need change in all connectors.
plugin/trino-mariadb/src/test/java/io/trino/plugin/mariadb/BaseMariaDbConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/main/java/io/trino/plugin/mariadb/MariaDbClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/test/java/io/trino/plugin/mariadb/TestMariaDbTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/test/java/io/trino/plugin/mariadb/TestMariaDbTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-mariadb/src/test/java/io/trino/plugin/mariadb/TestingMariaDbServer.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
from
b2add0b to
db5a2ae
Compare
Member
Author
No problem at all 🙂 Thanks for your review. |
Member
|
No new comments, resolved some and left replies on others. PTAL. LGTM otherwise. |
ebyhr
force-pushed
the
ebi/mariadb-connector
branch
from
db5a2ae to
44f25bc
Compare
hashhar
reviewed
Apr 25, 2022
...src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodeAllConnectors.java
Show resolved
Hide resolved
hashhar
approved these changes
Apr 25, 2022
Closed
Member
|
Very nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I excluded some code during porting from MySQL and MemSQL (e.g. type mapping of
bitandtimestamp), but let me know if we want to remove support more in the first PR.