Clarify config descriptions and add TODO comments

trinodb · Sep 30, 2024 · f31006c · f31006c
1 parent 9f3f3e5
commit f31006c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/execution/scheduler/NodeSchedulerConfig.java b/core/trino-main/src/main/java/io/trino/execution/scheduler/NodeSchedulerConfig.java
@@ -182,8 +182,9 @@ public NodeSchedulerConfig setOptimizedLocalScheduling(boolean optimizedLocalSch
         return this;
     }
 
+    // TODO: respect in pipelined mode
     @Config("node-scheduler.allowed-no-matching-node-period")
-    @ConfigDescription("How long scheduler should wait before failing a query for which hard task requirements (e.g. node exposing specific catalog) cannot be satisfied")
+    @ConfigDescription("How long scheduler should wait before failing a query for which hard task requirements (e.g. node exposing specific catalog) cannot be satisfied. Relevant for TASK retry policy only.")
     public NodeSchedulerConfig setAllowedNoMatchingNodePeriod(Duration allowedNoMatchingNodePeriod)
     {
         this.allowedNoMatchingNodePeriod = allowedNoMatchingNodePeriod;
@@ -195,8 +196,9 @@ public Duration getAllowedNoMatchingNodePeriod()
         return allowedNoMatchingNodePeriod;
     }
 
+    // TODO: respect in pipelined mode
     @Config("node-scheduler.exhausted-node-wait-period")
-    @ConfigDescription("Maximum time to wait for resource availability on preferred nodes before scheduling a remotely accessible split on other nodes")
+    @ConfigDescription("Maximum time to wait for resource availability on preferred nodes before scheduling a remotely accessible split on other nodes. Relevant for TASK retry policy only.")
     public NodeSchedulerConfig setExhaustedNodeWaitPeriod(Duration exhaustedNodeWaitPeriod)
     {
         this.exhaustedNodeWaitPeriod = exhaustedNodeWaitPeriod;