Skip to content

Commit

Permalink
Fix testParquetCaseSensitivity due to writer validation
Browse files Browse the repository at this point in the history
  • Loading branch information
raunaqmorarka committed Aug 28, 2024
1 parent ae0f973 commit 78f10ce
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,9 @@ public void testParquetCaseSensitivity(int rowCount)
assertThatFileFormat(PARQUET)
.withWriteColumns(ImmutableList.of(writeColumnA, writeColumnB))
.withReadColumns(ImmutableList.of(readColumn))
.withSession(PARQUET_SESSION_USE_NAME)
// Parquet writer validation will attempt to read back all written columns, while the reader is case-insensitive and does not support reading all columns for this case.
// Since this is not a valid scenario for Trino parquet writer, we disable parquet writer validation to avoid test failures
.withSession(getHiveSession(createParquetHiveConfig(true), new ParquetWriterConfig().setValidationPercentage(0)))
.withRowsCount(rowCount)
.withFileWriterFactory(fileSystemFactory -> new ParquetFileWriterFactory(fileSystemFactory, new NodeVersion("test-version"), TESTING_TYPE_MANAGER, new HiveConfig(), STATS))
.isReadableByPageSource(fileSystemFactory -> new ParquetPageSourceFactory(fileSystemFactory, STATS, new ParquetReaderConfig(), new HiveConfig()));
Expand Down

0 comments on commit 78f10ce

Please sign in to comment.