Skip to content

Type mapping related improvements and refactoring #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashhar merged 8 commits into from
Jan 23, 2024
Merged

Type mapping related improvements and refactoring #440

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f4c94a0
Update list of Trino types
hashhar Jan 20, 2024
626b224
Add more tests for array types
hashhar Jan 20, 2024
a5c3337
Extract ValueMapper and RowMapper to separate module
hashhar Jan 20, 2024
aa30861
Inline initialisation of POWERS_OF_TEN
hashhar Jan 20, 2024
6020789
Add test for chars padded with whitespace
hashhar Jan 21, 2024
b6d8c2c
Remove redundant else branches
hashhar Jan 20, 2024
77baefb
Use explicit equality when matching type signatures
hashhar Jan 21, 2024
0edbf9e
Reorder value mappers
hashhar Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion trino/sqlalchemy/datatype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,12 @@ def _format_value(self, value):
# 'map': MAP
# 'row': ROW
#
# === Mixed ===
# === Others ===
# 'ipaddress': IPADDRESS
# 'uuid': UUID,
# 'hyperloglog': HYPERLOGLOG,
# 'p4hyperloglog': P4HYPERLOGLOG,
# 'setdigest': SETDIGEST,
# 'qdigest': QDIGEST,
# 'tdigest': TDIGEST,
Comment on lines 172 to 173

@hovaesco hovaesco Jan 22, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two don't exist in SQLAlchemy as well.

@hovaesco hovaesco Jan 22, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for HyperLogLog types.

@hashhar hashhar Jan 22, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's still keep those in the map. It's useful to have it to show what types are mapped to what.

Note that some databases for example map their custom types to a custom SQLA type - we can do this too in future if we ever want to.

}
Expand Down