Provide query read-only property on dbapi cursor#323
Merged
hashhar merged 3 commits intotrinodb:masterfrom Feb 18, 2023
Merged
Conversation
hovaesco
reviewed
Jan 18, 2023
trino/client.py
Outdated
| return self._query_id | ||
|
|
||
| @property | ||
| def sql(self) -> Optional[str]: |
Member
There was a problem hiding this comment.
Perhaps a better name is query, it will follow the convention as used in query_id. Psycopg follow this as well.
mdesmet
force-pushed
the
feat/sql_property
branch
from
3cda689 to
9ecf881
Compare
mdesmet
changed the title
hovaesco
approved these changes
Jan 20, 2023
Member
hovaesco
left a comment
hovaesco
left a comment
There was a problem hiding this comment.
LGTM % Please change a commit message to "Provide query read-only property on dbapi"
mdesmet
force-pushed
the
feat/sql_property
branch
from
9ecf881 to
42a90c1
Compare
hashhar
force-pushed
the
feat/sql_property
branch
from
42a90c1 to
e82423c
Compare
Member
|
rebased |
hashhar
force-pushed
the
feat/sql_property
branch
from
e82423c to
dc669a1
Compare
Member
|
pre-commit failures would be fixed in #336 |
hashhar
approved these changes
Feb 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide sql read-only property on dbapi cursor
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:
* Provide executed SQL statement as a read-only property on dbapi's cursor