Merged
Conversation
findepi
reviewed
Feb 11, 2019
| @@ -1,191 +0,0 @@ | |||
| /** | |||
Member
Author
There was a problem hiding this comment.
👍 They merged your changes
| if (columnNameProperty.length() == 0) { | ||
| columnNames = new ArrayList<String>(); | ||
| if (columnNameProperty.isEmpty()) { | ||
| columnNames = Collections.emptyList(); |
Member
There was a problem hiding this comment.
any other copied classes need update?
Member
Author
There was a problem hiding this comment.
Yes, I verified the others (most are shims and not copied classes)
| <shadeBase>io.prestosql.hive.\$internal</shadeBase> | ||
|
|
||
| <dep.hive.version>2.3.4</dep.hive.version> | ||
| <dep.hive.version>3.0.0</dep.hive.version> |
Member
There was a problem hiding this comment.
I expect that Hive 3.0 is not an interesting version. Everybody who upgrades to Hive 3 will probably upgrade to 3.1.
I am ok with upgrading to 3.0 if
- we later upgrade to 3.1
- or we realize that my expectations do not match real world
Member
Author
There was a problem hiding this comment.
I agree, it's not interesting. This is to update the Parquet version since the one in 2.3.4 is broken.
dain
approved these changes
Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.