Add Dropdown to Change Timezones #805
Conversation
|
What is the motivation for this change? I would understand if it defaults to the local timezone of the browser of the user automatically and you can set it to just display UTC as stored in the database .. but I dont understand the logic to allow selection of any timezone |
Currently, the start time and timestamp is set to use the user's timezone. However sometimes a user might want to view the data in different timezones and allowing them to choose will provide additionally flexibility during debugging. Updating LineChartData to use epoch time instead of a formatted HH:MM string also makes the timestamps more consistent and unambiguous. |
|
I think this feature make sense for teams working across multiple timezones. Grafana and Datadog also have this feature. |
Agree seems like a valid dashboard feature. |
|
+1 on this feature make sense. In LinkedIn, we have developers from different timezones, and we've gained benefit from this changing timezone feature. This is also a common feature for dashboard applications. |
gateway-ha/src/main/java/io/trino/gateway/ha/domain/response/DistributionResponse.java
Outdated
Show resolved
Hide resolved
|
+1 - love adding this feature in. IMO, this feature should be utilized everywhere that we show a timestamp value:
|
|
Sounds like we have consensus to proceed. We talked about it also in the dev sync this week. The main thing we should make sure is that the setting is not isolated to one page but is applicable to the whole app and probably visible as switch everywhere .. and that any writing of data does not get messed up |
kjsbot
changed the title
kjsbot
changed the title
gateway-ha/src/main/java/io/trino/gateway/ha/domain/response/DistributionResponse.java
Outdated
Show resolved
Hide resolved
7 participants
Description
Currently the Trino Gateway UI does not have an option to change the timezone. This PR adds a dropdown to allow the user to select any timezone they want.
Testing