Pin Trino version in TestClusterStatsMonitor #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still failing :( |
andythsu
suggested changes
Oct 1, 2025
| { | ||
| private static final String TESTCONTAINERS_TRINO_IMAGE_SUBSTITUTE = "TESTCONTAINERS_TRINO_IMAGE_SUBSTITUTE"; | ||
| private static final String TRINO_IMAGE = "trinodb/trino"; | ||
| private static final String TRINO_IMAGE = "trinodb/trino:476"; |
There was a problem hiding this comment.
this is the wrong file. This file is to substitute the trinodb/trino image. We should change the version in
ebyhr
reviewed
Oct 1, 2025
gateway-ha/src/test/java/io/trino/gateway/ha/clustermonitor/TestClusterStatsMonitor.java
Show resolved
Hide resolved
|
Please fix "Release notes" section in the PR description. There is no need to mention this change because it only changes tests. |
ebyhr
changed the title
ebyhr
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR checks are currently failing because the ClusterStatsJmxMonitor is unable to find specific MBeans in Trino. This issue was introduced with Trino version 477.
Additional context and related issues
#773
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.