Db routing rules#772
Closed
mosabua wants to merge 2 commits intotrinodb:mainfrom
Closed
Conversation
Add API methods for creating and deleting rules.
Member
kbhatianr
reviewed
Dec 1, 2025
| INSERT INTO routing_rules (name, description, priority, conditionExpression, actions, routingRuleEngine) | ||
| VALUES (:name, :description, :priority, :condition, :actions, :routingRuleEngine) | ||
| """) | ||
| void createNoListSupport(String name, String description, Integer priority, String condition, String actions, RoutingRuleEngine routingRuleEngine); |
Contributor
There was a problem hiding this comment.
I don't see a difference in the create and the createNoListSupport.
Similarly, the update and the updateNoListSupport seems to be identical as well.
What's the purpose of these two methods being distinct?
kbhatianr
reviewed
Dec 1, 2025
|
|
||
| @SqlQuery("SELECT * FROM routing_rules") | ||
| @UseRowMapper(RoutingRulesStringToListMapper.class) | ||
| List<RoutingRule> getAllNoListSupport(); |
Contributor
There was a problem hiding this comment.
Why is this distinct from the getAll() method on line 33?
|
This pull request has gone a while without any activity. Ask for help on #trino-gateway-dev on Trino slack. |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Member
Author
|
A replacement PR from @EdenKik is in the works so this can stay closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of work from #635. .. for now just created new PR to preserve the work from @willmostly .. no idea when I will be able to proceed here .. potentially others can also use this as base
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required, with the following suggested text:
* Fix some things.