Add username info on Non OK HTTP Status code #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when Trino Gateway logs non-OK HTTP status codes, such as 401 Unauthorized, it does not include information about the user who initiated the request. This lack of context makes troubleshooting difficult, as it requires manually cross-referencing timestamps with external logs (e.g., Ingress) to identify the source of the problematic requests. This change enhances the logging mechanism to include the username in the log output for these error scenarios, significantly speeding up diagnostics and reducing operational overhead.
Member
|
The commit body is too long. Please follow https://trino.io/development/process.html#pull-request-and-commit-guidelines- from next time. |
Member
|
Got it. Will make sure to check if commit body is not too long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when Trino Gateway logs non-OK HTTP status codes, such as 401 Unauthorized, it does not include information about the user who initiated the request. This lack of context makes troubleshooting difficult, as it requires manually cross-referencing timestamps with external logs (e.g., Ingress) to identify the source of the problematic requests.
Additional context and related issues
Just to include the username in the log output for these error scenarios, significantly speeding up diagnostics and reducing needed to find those users in another place.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required, with the following suggested text: