Skip to content

Conversation

@maswin
Copy link
Member

@maswin maswin commented Aug 17, 2025

Description

Recently trino gateway build steps have started to fail - https://github.com/trinodb/trino-gateway/actions/runs/16999454601/job/48197983562

Trinogateway always pulls latest postgres image which might result in unexpected failures. Its better to pin to a version

Release notes

( X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Aug 17, 2025
@maswin maswin requested a review from ebyhr August 17, 2025 23:39
Copy link
Member

@oneonestar oneonestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently using postgres:16 in multiple places.
To ensure consistency, we should standardize on a single version.
Please either upgrade everything to 17 or align this with 16.

PostgreSQLContainer<?> postgres = new PostgreSQLContainer("postgres:16");

@maswin
Copy link
Member Author

maswin commented Aug 18, 2025

We are currently using postgres:16 in multiple places. To ensure consistency, we should standardize on a single version. Please either upgrade everything to 17 or align this with 16.

PostgreSQLContainer<?> postgres = new PostgreSQLContainer("postgres:16");

Aligned this version to 16

@ebyhr
Copy link
Member

ebyhr commented Aug 19, 2025

CI is still failing though the version pin itself is a good idea.
https://github.com/trinodb/trino-gateway/actions/runs/17046970320/job/48325182279?pr=753

@ebyhr ebyhr merged commit 4fd6d0d into trinodb:main Aug 19, 2025
2 checks passed
@github-actions github-actions bot added this to the 16 milestone Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants