Replace H2 use for testing with PostgreSQL#719
Open
Akanksha-kedia wants to merge 1 commit into
Open
Conversation
Contributor
Author
ebyhr
reviewed
Jul 9, 2025
Contributor
Author
|
I ll have to remove that
…On Wed, 9 Jul 2025 at 6:49 AM, Yuya Ebihara ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In webapp/pnpm-lock.yaml
<#719 (comment)>
:
> @@ -1,2936 +0,0 @@
-lockfileVersion: '9.0'
Is this change related to H2 removal?
—
Reply to this email directly, view it on GitHub
<#719 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZQUV6COWOFPLL5UJO33HRUZXAVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSOJZGQ4DSNRYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
2 times, most recently
from
d8bbdb2 to
c1469cc
Compare
Member
Why do we need to remove |
Contributor
Author
|
I mean i ll remove that commit
…On Wed, 9 Jul 2025 at 3:24 PM, Yuya Ebihara ***@***.***> wrote:
*ebyhr* left a comment (trinodb/trino-gateway#719)
<#719 (comment)>
I ll have to remove that
Why do we need to remove webapp/pnpm-lock.yaml?
—
Reply to this email directly, view it on GitHub
<#719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZXSTFAUPT5SWPXZ7RT3HTREZAVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANJRHE2TANZWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
c1469cc to
414ca10
Compare
Contributor
Author
|
@ebyhr please review |
ebyhr
reviewed
Jul 15, 2025
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
414ca10 to
52aaeaa
Compare
Contributor
Author
|
@ebyhr have resolved please review. |
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
52aaeaa to
d505b71
Compare
Contributor
Author
|
Contributor
Author
|
@mosabua please review. |
Contributor
Author
Contributor
Author
Contributor
Author
https://nexus-iq.visa.com/assets/index.html#/vulnerabilities/CVE-2021-42392
|
Contributor
Author
Member
|
We cut a new release now .. will hopefully be able to test soon .. can you rebase in the meantime |
Contributor
Author
|
Sure thing!
…On Fri, 19 Sep 2025 at 1:57 AM, Manfred Moser ***@***.***> wrote:
*mosabua* left a comment (trinodb/trino-gateway#719)
<#719 (comment)>
We cut a new release now .. will hopefully be able to test soon .. can you
rebase in the meantime
—
Reply to this email directly, view it on GitHub
<#719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZW2ILDDCWBZ7RQEHGD3TMIR3AVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMBZGU4DKMRQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
d505b71 to
11a5dd7
Compare
Contributor
Author
|
@mosabua please review |
Member
|
With #780 merged now .. can you rebase and adjust and make sure CI passes? |
Contributor
Author
|
Sure
…On Sun, 12 Oct 2025 at 4:39 AM, Manfred Moser ***@***.***> wrote:
*mosabua* left a comment (trinodb/trino-gateway#719)
<#719 (comment)>
With #780 <#780> merged now
.. can you rebase and adjust and make sure CI passes?
—
Reply to this email directly, view it on GitHub
<#719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZSW5GCHXLTFCR5C4ND3XGE2VAVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJTG4ZDGNZSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
02e1226 to
48fc01b
Compare
Contributor
Author
|
please review @mosabua |
Member
|
Can you rebase and resolve conflicts here @Akanksha-kedia ? It would be good to get this in |
Member
|
We definitely want to go ahead with this so I am adding the stale-ignore label to keep the PR from getting closed/lost. |
mosabua
added
stale-ignore
Member
|
Can you @Akanksha-kedia rebase and address the last few commits from @ebyhr so we can maybe get this merged and into a release soon |
Contributor
Author
|
Sure! Please i ll do that rebase and all hust kindly help to review and
merge so that i dnt need to rebase again n again. Or may be someone can co
author to get this done ?
…On Wed, 4 Mar 2026 at 1:01 PM, Manfred Moser ***@***.***> wrote:
*mosabua* left a comment (trinodb/trino-gateway#719)
<#719 (comment)>
Can you @Akanksha-kedia <https://github.com/Akanksha-kedia> rebase and
address the last few commits from @ebyhr <https://github.com/ebyhr> so we
can maybe get this merged and into a release soon
—
Reply to this email directly, view it on GitHub
<#719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZWUOQEOCS547S6RZVL4O7LW7AVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSOJVHAYDGMRYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
4 times, most recently
from
dba0335 to
532efd6
Compare
Contributor
Author
|
@mosabua please check |
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
7 times, most recently
from
693062c to
19a680e
Compare
Member
|
Could you fix the failing tests (or rebase if that is the source of the problem) @Akanksha-kedia .. or push again in case its a temporary failure and you verified it works locally for you Also could you have a look @ebyhr so we can get this finally in .. |
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
19a680e to
f4adf9a
Compare
Contributor
Author
|
@mosabua please go ahead with pr merge. |
ebyhr
reviewed
Mar 12, 2026
Member
|
I don't think this PR is ready for merge. |
ebyhr
removed
the
stale-ignore
Member
|
Can you remove the |
Contributor
Author
|
Okay
…On Tue, 14 Apr 2026 at 2:34 AM, Manfred Moser ***@***.***> wrote:
*mosabua* left a comment (trinodb/trino-gateway#719)
<#719 (comment)>
Can you remove the * START ***@***.*** */ and similar comments
@Akanksha-kedia <https://github.com/Akanksha-kedia> and address any other
concerns from @ebyhr <https://github.com/ebyhr> .. I would like to get
this in soon
—
Reply to this email directly, view it on GitHub
<#719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZURKYAOYEW3YVKW2XT4VVI7RAVCNFSM6AAAAACBBYEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMZZGYZDCOJVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
2 times, most recently
from
5eb5102 to
1a7bd80
Compare
Replace H2 in-memory database with PostgreSQL TestContainers for all test infrastructure. This eliminates the H2 test dependency and ensures tests run against the same database type used in production. Changes: - Remove H2 database dependency from pom.xml - Replace TestingJdbcConnectionManager to use PostgreSQL containers - Add TimestampColumnMapper to ExactMatchSourceSelectorsDao for proper timestamp handling with PostgreSQL - Update TestResourceGroupsManager to use name-based lookups instead of assuming specific auto-increment IDs - Update TestSpecificDbResourceGroupsManager to use TestcontainersUtils and withInitScript for database setup - Update TestHaGatewayManager cache expiration test to stop the PostgreSQL container to simulate database unavailability - Update TestJdbcConnectionManager to use PostgreSQL JDBC URLs - Remove unused seedRequiredData method from HaGatewayTestUtils
Akanksha-kedia
force-pushed
the
feature/new_pr
branch
from
1a7bd80 to
f880110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.