Add health check API endpoints#595
Conversation
ede6246 to
819c956
Compare
|
Might need to bind |
|
Have not really looked at the PR but I think we should agree on same names for those probes in Trino Gateway and Trino . What do you think are suitable URLs .. I think it could literally just be |
nineinchnick
left a comment
There was a problem hiding this comment.
AFAIK Trino doesn't yet have endpoints dedicated for probes. The z suffix is a convention started at Google, widely adopted in Kubernetes apps. I'm ok with that, OTOH there's little chance we'll have conflicts with other endpoints.
Fair enough .. i saw the healthz in others but the two you created @oneonestar are better .. so lets run with that then. |
819c956 to
d20f52e
Compare
72becaa to
034b5f6
Compare
mosabua
left a comment
There was a problem hiding this comment.
Mini nits for the docs, then good to go. Feel free to merge after fixing docs and testing locally
Co-authored-by: Manfred Moser <manfred@simpligility.ca>
Co-authored-by: Manfred Moser <manfred@simpligility.ca>
Co-authored-by: Manfred Moser <manfred@simpligility.ca>
Co-authored-by: Manfred Moser <manfred@simpligility.ca>
|
Great.,., just make sure you squash commits... |

Description
Add two new health check API endpoints:
/trino-gateway/livezand/trino-gateway/readyz.Additional context and related issues
/trino-gateway/livezalways returns 200./trino-gateway/readyzreturns 200 after the initial fetch from database and the first round of Trino cluster health check is completed. Otherwise, 503 will be returned.Release notes
(x) Release notes are required, with the following suggested text: