Merged
Conversation
mosabua
approved these changes
Apr 3, 2024
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Looks good. Just a few minor nits.
change commit message to
"Allow page permissions in UI"
and maybe have a few details in the message as bullet items
| } | ||
| }, [location]); | ||
|
|
||
| const lonout = () => { |
Chaho12
force-pushed
the
feature/jyoo/fix-page-permission
branch
from
aa73094 to
35ea5e3
Compare
- change langing page to /dashboard - Add hyperlink to Trino Gateway in UI
Chaho12
force-pushed
the
feature/jyoo/fix-page-permission
branch
from
35ea5e3 to
b60ae6c
Compare
Member
Author
|
rebased and updated :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some bug fix and doc improvements on page permissions, which includes the following
/to/dashboardTrino Gatewaytext in Logo is hyperlinklonoutgetMemberOfmay return non-lowercased string so lowercase it to use it with processPagePermissionsAdditional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
() Release notes are required, with the following suggested text:
*