Skip to content

Enforce errorprone UnnecessaryParentheses #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willmostly merged 1 commit into from
Mar 5, 2024
Merged

Enforce errorprone UnnecessaryParentheses #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gateway-ha/src/main/java/io/trino/gateway/baseapp/BaseApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ private void registerAuthFilters(Environment environment, Injector injector)
{
environment
.jersey()
.register(new AuthDynamicFeature((injector.getInstance(AuthFilter.class))));
.register(new AuthDynamicFeature(injector.getInstance(AuthFilter.class)));
logger.info("op=register type=auth filter item={}", AuthFilter.class);
environment.jersey().register(RolesAllowedDynamicFeature.class);
}
Expand Down
2 changes: 1 addition & 1 deletion gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ protected String plainTextFromGz(byte[] compressed)

protected boolean isCompressed(final byte[] compressed)
{
return (compressed[0] == (byte) (GZIPInputStream.GZIP_MAGIC))
return (compressed[0] == (byte) GZIPInputStream.GZIP_MAGIC)
&& (compressed[1] == (byte) (GZIPInputStream.GZIP_MAGIC >> 8));
}
}
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne \
-Xep:UnnecessaryParentheses:ERROR \
-Xep:UnusedVariable:ERROR</arg>
</compilerArgs>
<annotationProcessorPaths>
Expand Down