Skip to content

Merge yml files into docker-compose.yml#273

Merged
ebyhr merged 1 commit intotrinodb:mainfrom
ebyhr:ebi/docker-merge
Mar 6, 2024
Merged

Merge yml files into docker-compose.yml#273
ebyhr merged 1 commit intotrinodb:mainfrom
ebyhr:ebi/docker-merge

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Mar 5, 2024

No need to separate yml file because they're not reused. We had to jump other files to confirm the service definition.

@cla-bot cla-bot Bot added the cla-signed label Mar 5, 2024
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Mar 5, 2024
@ebyhr ebyhr requested review from mosabua and willmostly March 6, 2024 00:07
Copy link
Copy Markdown
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for also updating the docs.

@ebyhr ebyhr merged commit 2717e47 into trinodb:main Mar 6, 2024
@ebyhr ebyhr deleted the ebi/docker-merge branch March 6, 2024 21:12
@github-actions github-actions Bot added this to the 7 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

3 participants