Disallow JUnit assertions#267
Merged
ebyhr merged 1 commit intotrinodb:mainfrom Feb 29, 2024
ebyhr:ebi/junit-ban
Merged
Conversation
ebyhr
added
the
no-release-notes
mosabua
reviewed
Feb 29, 2024
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
In principal I think this is great. Just have to look at impl and refine a bit maybe.
mosabua
approved these changes
Feb 29, 2024
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Lets ship this, probably worth adding to trino some time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.