Use Airlift logger#260
Conversation
|
I like this approach. Not a review .. just an initial thought: We should we add docs on how to configure logging and add minimal config to jar with dependencies and docker container. |
|
|
||
| ### Configure logging | ||
|
|
||
| Path to `log.properties` needs to be set via `log.levels-file` JVM options |
There was a problem hiding this comment.
This should be added to release notes as a breaking change
There was a problem hiding this comment.
Also we need to explain what to configure in log.properties
separate lines of
javapackage=level
and what available levels are. In fact this should also be done better in the Trino docs btw
|
Rebased on main without any changes. |
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Some minor questions mostly .. but essentially good to go.
|
|
||
| ### Configure logging | ||
|
|
||
| Path to `log.properties` needs to be set via `log.levels-file` JVM options |
There was a problem hiding this comment.
| Path to `log.properties` needs to be set via `log.levels-file` JVM options | |
| Path to `log.properties` must be set via `log.levels-file` JVM options |
| Path to `log.properties` needs to be set via `log.levels-file` JVM options | ||
| like `-Dlog.levels-file=etc/log.properties`. | ||
|
|
||
| Find more information in the [logging properties](https://trino.io/docs/current/admin/properties-logging.html) |
There was a problem hiding this comment.
| Find more information in the [logging properties](https://trino.io/docs/current/admin/properties-logging.html) | |
| Use the `log.*` properties from the [Trino logging properties documentation](https://trino.io/docs/current/admin/properties-logging.html) for further configuration. |
probably .. but .. those have to also be set as -D parameters... need to explain that.
|
|
||
| ### Configure logging | ||
|
|
||
| Path to `log.properties` needs to be set via `log.levels-file` JVM options |
There was a problem hiding this comment.
Also we need to explain what to configure in log.properties
separate lines of
javapackage=level
and what available levels are. In fact this should also be done better in the Trino docs btw
| <dependency> | ||
| <groupId>io.dropwizard</groupId> | ||
| <artifactId>dropwizard-logging</artifactId> | ||
| <artifactId>dropwizard-request-logging</artifactId> |
There was a problem hiding this comment.
would be nice to get rid of this and just use jetty directly .. but for now it might have to stay
| <version>2.1.1</version> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
I assume this is the suggested use from airlift/trino for the servlet api
3 participants
Fixes #147