Skip to content

Improve and doc release process #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mosabua merged 1 commit into from
Mar 7, 2024
Merged

Improve and doc release process #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions docker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,3 @@ from the project checkout, and mounts it at `/opt/trino/gateway-ha-config.yml`.
By default the container health check uses the file `docker/bin/health-check`
mounted at `/usr/lib/trino/bin/health-check`. The scripts expects a 2XX response
from the server at `/api/public/backends`.

Comment thread
mosabua marked this conversation as resolved.
## Release

After the container images are built locally, a maintainer can login to
Docker Hub and use the `release-docker.sh` script to publish the locally built
images.
4 changes: 3 additions & 1 deletion docker/release-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ REPO=trinodb/trino-gateway
IMAGE=trino-gateway:$VERSION
TARGET=$REPO:$VERSION

docker/build.sh -r "$VERSION"
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"

$SCRIPT_DIR/build.sh -r "$VERSION"

architectures=(amd64 arm64 ppc64le)

Expand Down
39 changes: 39 additions & 0 deletions docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,42 @@ for more details.

Want to help build Trino Gateway? Check out our [contributing
documentation](../.github/CONTRIBUTING.md)


## Release process

A full release process consists of the following steps:

Merge the pull request for the release notes and pull the changes locally:

```shell
cd trino-gateway
git checkout main
git pull
Comment thread
mosabua marked this conversation as resolved.
```

Run a Maven release build:

```shell
./mvnw clean release:prepare release:perform
```

A successful release build performs the necessary commits, and pushes the
binaries to Maven Central staging.

Close and release the staging repository, and wait until the sync to Central is
completed. Confirm the presence of the artifacts at
[https://repo.maven.apache.org/maven2/io/trino/gateway/gateway-ha/](https://repo.maven.apache.org/maven2/io/trino/gateway/gateway-ha/).

Ensure that you are logged into Docker Hub with suitable permissions, and run
the container release script with the version number that was just released,
for example `6`:

```shell
docker/release-docker.sh 6
```

Once completed, verify the availability at
[https://hub.docker.com/r/trinodb/trino-gateway](https://hub.docker.com/r/trinodb/trino-gateway).

Announce the release on Trino Slack and LinkedIn.