Skip to content

Remove restart policy from docker compose file#250

Merged
ebyhr merged 1 commit intotrinodb:mainfrom
ebyhr:ebi/docker-restart
Feb 15, 2024
Merged

Remove restart policy from docker compose file#250
ebyhr merged 1 commit intotrinodb:mainfrom
ebyhr:ebi/docker-restart

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Feb 14, 2024

The expected restart policy should be decided by users, not us.
Restarting these containers automatically looks annoying for me.

@cla-bot cla-bot Bot added the cla-signed label Feb 14, 2024
@ebyhr ebyhr requested review from mosabua and wendigo February 14, 2024 11:23
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 15, 2024

Fine by me. These files are only for local playing around anyway. I would like to merge the general update of the docker stuff first though.

#209

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 15, 2024

Thoughts @rdsarvar @willmostly @vishalya and @Chaho12 ?

Copy link
Copy Markdown
Member

@Chaho12 Chaho12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ebyhr ebyhr merged commit 38e1f88 into trinodb:main Feb 15, 2024
@ebyhr ebyhr deleted the ebi/docker-restart branch February 15, 2024 04:45
@github-actions github-actions Bot added this to the 6 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants