Inline dependency version#235
Merged
ebyhr merged 1 commit intotrinodb:mainfrom Feb 6, 2024
ebyhr:ebi/pom-dependency
Merged
Conversation
Also, move some versions to gateway-ha.
mosabua
reviewed
Feb 3, 2024
|
|
||
| </properties> | ||
|
|
||
| <dependencyManagement> |
Member
There was a problem hiding this comment.
If we stick with one module .. we could get rid of dependency management altogether
mosabua
reviewed
Feb 3, 2024
| <air.check.skip-spotbugs>true</air.check.skip-spotbugs> | ||
| <air.check.skip-pmd>true</air.check.skip-pmd> | ||
|
|
||
| <!-- dependency versions --> |
Member
There was a problem hiding this comment.
Some of these were needed as overrides since there were different versions coming in between dropwizard and airbase .. and now also airlift
Member
There was a problem hiding this comment.
And we might have to check that our override works and potentially enforce via depMgt
Contributor
There was a problem hiding this comment.
Airlift comes with latest :)
Member
|
If we do this clean up we might as well clean up dependencyManagement as well and we have to verify that we still get a compatible end result of versions with the mix of dropwizard, airflit and airbase ... and esp airbase might overlap |
wendigo
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows dependency declaration style in Trino project.