Use JDBI for resource_groups_global_properties#230
Merged
mosabua merged 1 commit intotrinodb:mainfrom Feb 15, 2024
ebyhr:ebi/jdbi-resource-groups-global-properties
Merged
Use JDBI for resource_groups_global_properties#230mosabua merged 1 commit intotrinodb:mainfrom ebyhr:ebi/jdbi-resource-groups-global-properties
mosabua merged 1 commit intotrinodb:mainfrom
ebyhr:ebi/jdbi-resource-groups-global-properties
Conversation
mosabua
reviewed
Feb 7, 2024
| { | ||
| String jdbcUrl = configuration.getJdbcUrl(); | ||
| if (routingGroupDatabase != null) { | ||
| jdbcUrl = jdbcUrl.substring(0, jdbcUrl.lastIndexOf('/') + 1) + routingGroupDatabase; |
Member
There was a problem hiding this comment.
will this work for MySQL, PostgreSQL and Oracle or are we assuming too much about the format of the jdbc url .. should we at least add some mention in the docs that we rely on the db name in the jdbc url?
mosabua
approved these changes
Feb 15, 2024
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Lets roll with this for now and see. Worst case we have to refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #229