Merged
Conversation
ebyhr
reviewed
Jan 31, 2024
mosabua
reviewed
Feb 1, 2024
|
|
||
| TAG_PREFIX="trino-gateway:${TRINO_GATEWAY_VERSION}" | ||
|
|
||
| # Use ubi9 minimal as it's more secure |
Member
There was a problem hiding this comment.
remove this comment .. more secure than what?
mosabua
reviewed
Feb 1, 2024
Member
|
Please also add this to the README in the docker folder |
andythsu
force-pushed
the
docker
branch
2 times, most recently
from
4b03f30 to
b32ce52
Compare
ebyhr
reviewed
Feb 1, 2024
Comment on lines
+86
to
+88
| export TRINO_GATEWAY_BASE_IMAGE=<image> | ||
| ./build.sh |
Member
There was a problem hiding this comment.
build.sh already offers some arguments h,a,r,j to changer the behavior. Why do we need to use an environment variable for the base image?
Member
Author
There was a problem hiding this comment.
do we want to create a new argument to change the base image then? Because right now the base image is using the one on dockerhub, but we will need to use our own base image to build the docker image.
Member
There was a problem hiding this comment.
The script also uses a bunch of env variables.. so its kinda inconsistent .. I think of the trino image more like the java home path to be honest
mosabua
reviewed
Feb 1, 2024
| ./build.sh -r 4 | ||
| ``` | ||
|
|
||
| Set the environment variable `TRINO_GATEWAY_BASE_IMAGE` to use a specific base image to build Trino Gateway image. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting a custom base image allows building a docker image in a siloed environment with no access to DockerHub or replacing the image with a custom version of the base image. Or both..