Make ch.qos.logback dependency declarative#214
Merged
ebyhr merged 1 commit intotrinodb:mainfrom Jan 30, 2024
Merged
Conversation
ebyhr
reviewed
Jan 30, 2024
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Please capitalize the commit title. https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages
andythsu
changed the title
Member
Author
done |
ebyhr
approved these changes
Jan 30, 2024
andythsu
force-pushed
the
logback2
branch
2 times, most recently
from
008923b to
fd1777c
Compare
Member
|
Let us know when you pushed the updated commit messages and such @andythsu .. then we can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.4.14is what dropwizard v:stable is using, so we will just use this version