Skip to content

Replace deprecated NewCookie constructor with builder #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Jan 28, 2024
Merged

Replace deprecated NewCookie constructor with builder #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions gateway-ha/src/main/java/io/trino/gateway/ha/security/SessionCookie.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,26 @@ private SessionCookie() {}

public static NewCookie getTokenCookie(String token)
{
return new NewCookie(OAUTH_ID_TOKEN,
token, "/", "", "",
60 * 60 * 24, true);
return new NewCookie.Builder(OAUTH_ID_TOKEN)
.value(token)
.path("/")
.domain("")
.comment("")
.maxAge(60 * 60 * 24)
.secure(true)
.build();
}

public static Response logOut()
{
NewCookie cookie = new NewCookie(OAUTH_ID_TOKEN,
"logout", "/", "", "",
0, true);
NewCookie cookie = new NewCookie.Builder(OAUTH_ID_TOKEN)
.value("logout")
.path("/")
.domain("")
.comment("")
.maxAge(0)
.secure(true)
.build();
return Response.ok("You are logged out successfully.")
.cookie(cookie)
.build();
Expand Down