Skip to content

Add CI job for Docker build#198

Merged
ebyhr merged 1 commit intotrinodb:mainfrom
ebyhr:ebi/docker-ci
Jan 26, 2024
Merged

Add CI job for Docker build#198
ebyhr merged 1 commit intotrinodb:mainfrom
ebyhr:ebi/docker-ci

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jan 26, 2024

Fixes #197

@cla-bot cla-bot Bot added the cla-signed label Jan 26, 2024
Comment thread .github/workflows/ci.yml Outdated
@ebyhr ebyhr marked this pull request as ready for review January 26, 2024 23:22
@ebyhr ebyhr requested a review from mosabua January 26, 2024 23:22
Comment thread .github/workflows/ci.yml Outdated
run: $MAVEN clean verify
- uses: docker/setup-qemu-action@v2
with:
platforms: arm64,ppc64le
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about amd64 ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also .. the build script does all three on its own ..

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.. lets merge and have it run!

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jan 26, 2024

Sure makes the build take longer.

@ebyhr ebyhr merged commit 4c4da9e into trinodb:main Jan 26, 2024
@ebyhr ebyhr deleted the ebi/docker-ci branch January 26, 2024 23:55
@github-actions github-actions Bot added this to the 6 milestone Jan 26, 2024
@mosabua mosabua mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Add CI job for Docker build

2 participants