Merged
Conversation
mosabua
force-pushed
the
docs-nav
branch
3 times, most recently
from
cad9f43 to
cb79344
Compare
- Add logo on each page - Use same layout in readme - Use only three columns but add item lists
Chaho12
approved these changes
Jan 24, 2024
Member
Chaho12
left a comment
Chaho12
left a comment
There was a problem hiding this comment.
I guess no more bolding current page link?
LGTM 👍
Member
Author
No .. ultimately I think we need to get a little website that deploys to github pages via a different branch going. I know how to do all that .. just need to figure out how this relates to plans I have with the Trino docs themselves.. |
willmostly
approved these changes
Jan 26, 2024
Contributor
willmostly
left a comment
willmostly
left a comment
There was a problem hiding this comment.
LGTM. It will be nice once Sphinx is introduced so we don't have to change each doc page manually.
ebyhr
approved these changes
Jan 26, 2024
Member
Author
|
Thank you @ebyhr @willmostly and @Chaho12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review @willmostly @vishalya @Chaho12