Fix Spark image healthcheck flakiness#153
Merged
hashhar merged 2 commits intotrinodb:masterfrom Nov 1, 2022
hashhar:hashhar/spark-fixes
Merged
Fix Spark image healthcheck flakiness#153hashhar merged 2 commits intotrinodb:masterfrom hashhar:hashhar/spark-fixes
hashhar merged 2 commits intotrinodb:masterfrom
hashhar:hashhar/spark-fixes
Conversation
nineinchnick
approved these changes
Oct 31, 2022
It is unused.
localhost can resolve to either IPv4 or IPv6 address at runtime and depending on the configuration of the Docker daemon IPv6 may not work leading to failing healthchecks during runtime.
ebyhr
approved these changes
Oct 31, 2022
Member
|
@hashhar Will you release a new version after merging this PR? |
Member
Author
|
@ebyhr Yes. I've verified this fixes the remaining failures in trinodb/trino#14810 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.