Conversation
wendigo
force-pushed
the
serafin/make-jdk-17-default
branch
2 times, most recently
from
a715b88 to
cf8c9ea
Compare
wendigo
requested review from
findinpath,
hashhar,
kokosing and
martint
and removed request for
findinpath
|
I'm just wondering, how do we make sure that the images do start with the changes we are doing before making a new docker release? |
kokosing
left a comment
kokosing
left a comment
There was a problem hiding this comment.
How to test it with Trino? It would be great to make sure we are still able to run all tests in Trino after releasing these images.
|
@kokosing it would be possible to test it if we were releasing snapshots. But since we are not, we can rely only on manual testing and/or testing after a release |
|
I would test it manually, at least few product tests that are using TLS or KRB. |
|
Since the previous version includes everything except this PR I think we can merge this (after some manual tests) and perform a release. That way we always have a clean version of docker-images we can use in Trino if this fails. |
|
I was actually having in mind a kind of smoke test for the image. See that it starts successfully and performs a basic set of operation(s) for which it was conceived and take it back down. The test that I'm speaking about is definitely not dependent on Trino. Obviously this is not to be done in the scope of this PR, but rather as a potential follow-up if the idea gets more traction. |
|
The commit message is a bit misleading: Maybe "Use Java 17 runtime" fits more the purpose of the commit. |
Remove JDK 11 from docker images
wendigo
force-pushed
the
serafin/make-jdk-17-default
branch
from
cf8c9ea to
c275e6e
Compare
4 participants
No description provided.