Add PostgreSQL JDBC driver jar to Iceberg image#125
Merged
ebyhr merged 1 commit intotrinodb:masterfrom May 9, 2022
Merged
Conversation
findepi
reviewed
May 6, 2022
testing/spark3.0-iceberg/Dockerfile
Outdated
| RUN wget -nv "https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-spark-runtime-${ICEBERG_JAR_VERSION}/${ICEBERG_VERSION}/iceberg-spark-runtime-${ICEBERG_JAR_VERSION}-${ICEBERG_VERSION}.jar" | ||
|
|
||
| # install PostgreSQL driver for JDBC catalog | ||
| RUN wget -nv --no-check-certificate "https://jdbc.postgresql.org/download/postgresql-42.3.5.jar" |
Member
There was a problem hiding this comment.
Why do we need --no-check-certificate? (we don't need it above; also, well, it's not secure)
Member
Author
There was a problem hiding this comment.
I faced the below error when building the image. Switched to maven now.
Step 11/14 : RUN wget -nv --no-check-certificate "https://jdbc.postgresql.org/download/postgresql-42.3.5.jar"
---> Running in 5755549870dd
WARNING: cannot verify jdbc.postgresql.org's certificate, issued by ‘/C=US/O=Let's Encrypt/CN=R3’:
Issued certificate has expired.
2022-05-06 06:24:27 URL:https://jdbc.postgresql.org/download/postgresql-42.3.5.jar [1041066/1041066] -> "postgresql-42.3.5.jar" [1]
Member
There was a problem hiding this comment.
Interesting. Both my browser and wget running locally had no problem downloading https://jdbc.postgresql.org/download/postgresql-42.3.5.jar.
Member
Author
There was a problem hiding this comment.
Me too. Another option is installing ca-certificates beforehand.
yum install ca-certificates
Member
There was a problem hiding this comment.
installing ca-certificates is definitely better than --no-check-certificate
findepi
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to trinodb/trino#11772