Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions testing/spark3.0-iceberg/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@

FROM testing/centos7-oj11:unlabelled

ARG SPARK_VERSION=3.1.2
ARG SPARK_VERSION=3.2.1
ARG HADOOP_VERSION=3.2
ARG ICEBERG_VERSION=0.12.1
ARG ICEBERG_VERSION=0.13.1
# ICEBERG_JAR_VERSION is derived from: <spark-version>_<scala-version>
ARG ICEBERG_JAR_VERSION=3.2_2.12
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spark 3.2.1 vs iceberg-spark 3.2.2 -- should these match?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.12 is the Scala version number, not the spark minor version. They're both referring to Spark 3.2.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding a code comment?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment


ARG SPARK_ARTIFACT="spark-${SPARK_VERSION}-bin-hadoop${HADOOP_VERSION}"

Expand All @@ -29,7 +31,7 @@ RUN set -xeu; \
WORKDIR ${SPARK_HOME}/jars

# install Iceberg
RUN wget -nv "https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-spark3-runtime/${ICEBERG_VERSION}/iceberg-spark3-runtime-${ICEBERG_VERSION}.jar"
RUN wget -nv "https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-spark-runtime-${ICEBERG_JAR_VERSION}/${ICEBERG_VERSION}/iceberg-spark-runtime-${ICEBERG_JAR_VERSION}-${ICEBERG_VERSION}.jar"

ENV PATH="${SPARK_HOME}/bin:${PATH}"

Expand Down