Remove DB initialization from tests#305
Merged
nineinchnick merged 1 commit intotrinodb:mainfrom Feb 15, 2025
Merged
Conversation
mosabua
approved these changes
Feb 14, 2025
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Looks good. I don't think we need to create the empty db. Feel free to merge if this turns green.
Also this is just a test change so we dont have to cut another release of the chart in my opinion.
nineinchnick
added
the
ignore-for-release
nineinchnick
approved these changes
Feb 15, 2025
Member
|
This fixes the CI, but it should have been merged before #289. The only reason the release went through, is that we're missing the |
Member
|
The weird thing is that the PR for the release fully worked .. it only failed when we merged that to main.. anyway it all seems good now. What do we need to add @nineinchnick ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DB is now initialized by Flyway