Remove deprecated settings from gateway config#296
Conversation
mosabua
left a comment
There was a problem hiding this comment.
This looks good and I think we can merge now .. we wont cut a 13.x chart .. and are working towards Trino Gateway and the upstream PR is merged.
|
Also @willmostly .. thoughts? |
|
We can't merge this since the CI is red. |
Fair.. so it means we have to merge it after the cut Trino Gateway 14 and publish the container .. but before we get this chart released .. I will keep that in mind .. |
|
@mosabua please don't merge PRs with red CI, it should have been re-run. If you wanted to merge this before #289, to be included in the 1.14.0 release of the Chart, the Gateway version should have been bumped separately, before bumping the chart version. This is to avoid releasing patch versions of the chart if anything goes wrong. |
|
Ok.. sounds good.. It was green on the branch builds and only turned red after the merge. So I am not sure what really happened. |
Remove
HaGatewayProviderModule,ActiveClusterMonitor,ClusterStateListenerModule,and
ClusterStatsMonitorModulefrom Trino Gateway config file.Gateway loads fundamental modules by default after trinodb/trino-gateway#597.
This PR should be merged together with Trino Gateway 14 upgrade.