Add support for configuring exchange manager properties#29
Merged
hashhar merged 1 commit intotrinodb:mainfrom Mar 3, 2022
Merged
Add support for configuring exchange manager properties#29hashhar merged 1 commit intotrinodb:mainfrom
hashhar merged 1 commit intotrinodb:mainfrom
Conversation
Member
Author
|
cc @hashhar, @joshthoward |
Member
|
This looks good to me. I would want to be able to pass through arbitrary configs in the future without having explicitly add configs to the chart, but that is separate from this feature enhancement. |
Member
Author
|
Yes we are able to, e.g., use of |
hashhar
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to trinodb/trino#11154, want to exchange-manager.properties as part of the dev setup for Helm charts.
Locally tested and deployed on EKS:
and verified cluster is running in batch mode with S3 used for spooling.