Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fabs co_name #58

Merged
merged 3 commits into from
Sep 20, 2018
Merged

Fix/fabs co_name #58

merged 3 commits into from
Sep 20, 2018

Conversation

albertjan
Copy link

Sorry @eah13 I should have stressed this more yesterday, but fabs needs to be a seperate function because otherwise the co_name of "abs" becomes "fabs" causing abs not to be recognised as an internal function.

😄

@albertjan albertjan requested a review from eah13 September 20, 2018 11:50
@eah13
Copy link
Member

eah13 commented Sep 20, 2018

Whoops. Thx. I understood that at the time but it had escaped me by the time I did this last night.

Fixed a missing semi and will merge once the builds pass.

Quick question RE the automated dist build. Last night I don't think it autotagged skulpt-dist after i made a release in this repo, so I ended up making a release myself. Am I missing something on the process here or did I just get impatient?

@eah13 eah13 merged commit 905e3d0 into master Sep 20, 2018
@eah13 eah13 deleted the fix/fabs branch September 20, 2018 12:42
@albertjan
Copy link
Author

🤦‍♂️

@albertjan
Copy link
Author

You need to tag master with the version number and then run a build, what I usually do is make sure I make that tag before the build finishes 😄 As soon as it sees there's a new tag it updates skulpt-dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants