RC0: Embree 4 Support

[mikedh]

Not working, plumbing hooked up.

[alisoufali-trendplus]

Not working, plumbing hooked up.

Hi, I've seen that you are trying to make embree 4 working. There is a code named raybender which managed to make python bindings for the embree the other way. It might work

https://github.com/cvg/raybender

[schwarrx]

@mikedh would love to see this working. Let me know how I can help. Excited to use embreex with Embree 4 on Apple M2!

[LeeJB-48]

Hi, i'm using trimesh and apple silicon macos.
I needed to do huge amount of ray intersection on mesh but embreex didn't support macos arm64,
so i forked embreex repository and made upgrade to embree4
I used ai to make those upgrade.

And it works well in both linux and macos arm64.

Feel free to use my code

https://github.com/LeeJB-48/embreex4

[mikedh]

Great point! It's probably OK to let Claude finish 3 year old PR's haha. I fixed the build and the wheels are usable (https://github.com/trimesh/embreex/actions/runs/19942366491) and they were performing well, however it was failing the upstream trimesh test_ray.py:

INFO           test_ray.py:50    Measured [791512.52099 684504.93676] rays/second with embree 1
INFO            generic.py:257   loading mesh from: /home/mikedh/trimesh/models/unit_sphere.STL
INFO           test_ray.py:50    Measured [48734.76568 48177.4972 ] rays/second with embree 0
.
======================================================================
FAIL: test_multiple_hits (__main__.RayTests.test_multiple_hits)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mikedh/trimesh/tests/test_ray.py", line 154, in test_multiple_hits
    assert len(g.np.unique(index_triangles)) == 2
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

----------------------------------------------------------------------
Ran 9 tests in 5.351s

FAILED (failures=1)

If I had to guess it's probably that the new robust flag doesn't like rays starting inside a solid? @LeeJB-48 does your branch pass test_ray.py?

I had also forked the upstream raybender and got it to build wheels (https://github.com/mikedh/raybender) as it has a nicer structure (pybind11 stuff is easier to maintain vs Cython stuff imo) but I didn't get it over the line as I was hoping to have an API that actually worked on Scenes, not just triangle soups.

We should probably get embreex over the line as-is.

[LeeJB-48]

Thanks for making embree 4 support !
I really appreciate it !

[mikedh]

Thanks for the follow up on this ancient PR! Anyone watching if you want to test the release candidate with pip install --pre --upgrade embreex that would be awesome. It's still failing the 1 out of 9 upstream trimesh tests but that case is for undefined behavior (hit-on-crest-edge) and I think is fine. I'll try to do a non-candidate release of this in a month or two after running on this more.