Skip to content

upgrade nanobind #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2024
Merged

upgrade nanobind #176

merged 1 commit into from
Dec 31, 2024

Conversation

trim21
Copy link
Owner

@trim21 trim21 commented Dec 31, 2024

No description provided.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (783c33b) to head (6f7748d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files           9        9           
  Lines         779      779           
  Branches       84       84           
=======================================
  Hits          740      740           
  Misses         28       28           
  Partials       11       11           
Flag Coverage Δ
3.10 94.60% <ø> (ø)
3.11 94.99% <ø> (ø)
3.12 94.99% <ø> (ø)
3.13 94.99% <ø> (ø)
3.9 99.56% <ø> (ø)
pypy3.10 99.56% <ø> (ø)
pypy3.9 99.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 31, 2024

CodSpeed Performance Report

Merging #176 will degrade performances by 38.51%

Comparing nanobind (6f7748d) with master (783c33b)

Summary

❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master nanobind Change
test_benchmark_encode_single_file_torrent_py 788.1 µs 1,281.6 µs -38.51%

@trim21 trim21 merged commit a7eaf39 into master Dec 31, 2024
50 of 51 checks passed
@trim21 trim21 deleted the nanobind branch December 31, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant