Wolfgangbeer/ch3876/ersetzen der chakra menu component durch #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelkes
suggested changes
Sep 1, 2020
kelkes
approved these changes
Sep 5, 2020
src/menu/menu-item-link.tsx
Outdated
| if (!isDisabled) closeMenu(); | ||
| }, [closeMenu, isDisabled]); | ||
|
|
||
| const className = cx( |
There was a problem hiding this comment.
vl auf const classNames oder const tailwindString umbenennen damit wir nicht 2mal den selben Namen bei unterschiedlichen Dingen haben.
| @@ -3,6 +3,9 @@ const tailwindcssui = require('@tailwindcss/ui'); | |||
| const defaultTheme = require('tailwindcss/defaultTheme'); | |||
|
|
|||
| module.exports = { | |||
| future: { | |||
| removeDeprecatedGapUtilities: true, | |||
There was a problem hiding this comment.
würde diese purge option noch mit einfügen. Laut Adam Watan ises nun save aggressiver zu purgen und diese option wird in einem zukünftigen tw-update sowieso default sein.
Aktuell is das purge Verhalten auf conservative gestellt.
Hier der Link zum gemergeten PR vom Tailwind-Team zum kommenden tailwind-update:
tailwindlabs/tailwindcss#2288
future: {
removeDeprecatedGapUtilities: true,
purgeLayersByDefault: true,
},
philippmossier
approved these changes
Sep 7, 2020
|
Naming Changes sind eingearbeitet. Update von der config Option wird separat gemacht |
kelkes
deleted the
wolfgangbeer/ch3876/ersetzen-der-chakra-menu-component-durch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Komponenten:
MenuMenuButtonMenuListMenuDividerMenuItemMenuItemLinkDie Menu Komponente ist komplett via Keyboard bedienbar und wird von einem Screenreader korrekt announced. Folgetask wenn dieser gemerged und gepublished ist:
sunrocks operation-center und retailer-portal auf die neue design system version updaten und Breaking Changes einarbeiten.