Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL 1.3 problems #14

Open
beanz opened this issue Apr 19, 2012 · 1 comment
Open

SDL 1.3 problems #14

beanz opened this issue Apr 19, 2012 · 1 comment

Comments

@beanz
Copy link

beanz commented Apr 19, 2012

Compiled okay a few days ago, but today I needed to add:

+#ifndef SDL_NOEVENT
+#define SDL_NOEVENT SDL_FIRSTEVENT
+#endif

to compile with SDL 1.3.0 on Linux.

There is also a segfault on hitting 'r' caused by:

http://forums.libsdl.org/viewtopic.php?t=6953&sid=4ad9b6fa92abc4d5979f8bce00bc0367

which can be hacked around by commenting out the SDL_FreeSurface call in resize(...).

(There may be a good reason for it but while looking at resize(...), it looks a little odd that the #if OPENGL code has a SDL_FreeSurface call but the #else doesn't.)

Regards,
Mark.

triffid added a commit that referenced this issue Apr 19, 2012
Reported-by: Mark Hindess <[email protected]>
@triffid
Copy link
Owner

triffid commented Apr 19, 2012

Thanks for this, either I didn't read the SDL docs properly or the ones I was using were wrong:
http://www.libsdl.org/docs/html/sdlsetvideomode.html says

The surface returned is freed by SDL_Quit() and should nt be freed by the caller.

http://hg.libsdl.org/SDL/rev/faa9fc8e7f67 <-- seems a bit silly to me that someone removed something marked "do not remove".

On my system, with your proposed patch, compile fails with 'error: 'SDL_FIRSTEVENT' undeclared', looks like we'll have to explicitly set it to 0 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants