fix overflow on total_{in, out} on windows#473
Merged
folkertdev merged 1 commit intomainfrom Feb 16, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bjorn3
approved these changes
Feb 16, 2026
EliteTK
added a commit
to astral-sh/uv
that referenced
this pull request
Mar 7, 2026
Extracting a wheel on windows which has a larger total uncompressed size than 4GiB leads to panics as seen in #18316 (comment) This is caused by trifectatechfoundation/zlib-rs#472. zlib 0.6.2 includes trifectatechfoundation/zlib-rs#473 which addresses this issue.
EliteTK
added a commit
to astral-sh/uv
that referenced
this pull request
Mar 7, 2026
…n Windows (#18362) ## Summary Extracting a wheel on windows which has a larger total uncompressed size than 4GiB leads to panics as seen in <#18316 (comment)>. This is caused by <trifectatechfoundation/zlib-rs#472>. `zlib-rs` 0.6.2 includes <trifectatechfoundation/zlib-rs#473> which addresses this issue. ## Test Plan Manually verified via: ``` uv pip install --no-cache-dir https://repo.radeon.com/rocm/windows/rocm-rel-7.2/rocm_sdk_devel-7.2.0.dev0-py3-none-win_amd64.whl ``` On a Windows 11 VM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #472
On windows the internal counter for
total_{in, out}is a 32-bit integer, which can overflow on modern systems. In our stable API we can do the bookkeeping ourselves and always use 64-bit integers.I plan to test this in
flate2, which we also run in our test suite.