Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface newtypes #879

Merged
merged 27 commits into from
Oct 22, 2024
Merged

Interface newtypes #879

merged 27 commits into from
Oct 22, 2024

Commits on Oct 13, 2024

  1. Implement newtypes for UserId, GroupId, ProcessId and DeviceId 

    keeping the value private as per
https://www.howtocodeit.com/articles/ultimate-guide-rust-newtypes#newtype-essentials

Formatting
    @van-sprundel
    van-sprundel committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    9ceeae1 View commit details
    Browse the repository at this point in the history

  2. Fix breaking changes in test env

    @van-sprundel
    van-sprundel committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    4d09d20 View commit details
    Browse the repository at this point in the history

  3. Return docs

    @van-sprundel
    van-sprundel committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    479ee49 View commit details
    Browse the repository at this point in the history

  4. Formatting

    @van-sprundel
    van-sprundel committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    41b0e08 View commit details
    Browse the repository at this point in the history

  5. Don't use newtypes for groups_buffer 

    getgrouplist doesn't like it.
    @van-sprundel
    van-sprundel committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    99adc61 View commit details
    Browse the repository at this point in the history

  6. Format

    @van-sprundel
    van-sprundel committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    037f45a View commit details
    Browse the repository at this point in the history

  7. Don't dereference pointer when type is not equal 

    Again, we're working with newtypes here, not the ids.
    @van-sprundel
    van-sprundel committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    74a329d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'main' into interface-newtypes

    @van-sprundel
    van-sprundel authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    fcdf3f1 View commit details
    Browse the repository at this point in the history

  2. Fix merge 

    Never doing that in GH again...
    @van-sprundel
    van-sprundel committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    845991d View commit details
    Browse the repository at this point in the history

  3. Replace impl const fn new with OnceCell

    @van-sprundel
    van-sprundel committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    673acda View commit details
    Browse the repository at this point in the history

  4. Formatting

    @van-sprundel
    van-sprundel committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    82765a0 View commit details
    Browse the repository at this point in the history

  5. Use static TEST_USER_ID with OnceLock

    @van-sprundel
    van-sprundel committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d1eee33 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into interface-newtypes

    @van-sprundel
    van-sprundel authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    29ebf01 View commit details
    Browse the repository at this point in the history

  2. Make pid() return ProcessId

    @van-sprundel
    van-sprundel committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7780bd6 View commit details
    Browse the repository at this point in the history

  3. Remove redundant get() call

    @van-sprundel
    van-sprundel committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ffa3f46 View commit details
    Browse the repository at this point in the history

  4. Add UserId::ROOT const

    @van-sprundel
    van-sprundel committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    10a45ed View commit details
    Browse the repository at this point in the history

  5. keep id structs the same size as their field

    @van-sprundel
    van-sprundel committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e2ca69e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Use ROOT const on more places

    @van-sprundel
    van-sprundel committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1a3fd1b View commit details
    Browse the repository at this point in the history

  2. Use transparent struct on GroupId, remove transparent on UserId, Proc… 

    …essId and DeviceId
    @van-sprundel
    van-sprundel committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    458efe7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into interface-newtypes

    @van-sprundel
    van-sprundel authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9633bab View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Merge branch 'main' into interface-newtypes

    @van-sprundel
    van-sprundel authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    513f276 View commit details
    Browse the repository at this point in the history

  2. Add is_valid for ProcessId

    @van-sprundel
    van-sprundel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f62cc4e View commit details
    Browse the repository at this point in the history

  3. Use UserId::ROOT

    @van-sprundel
    van-sprundel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8eff83f View commit details
    Browse the repository at this point in the history

  4. Remove more get calls

    @van-sprundel
    van-sprundel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fd07c7e View commit details
    Browse the repository at this point in the history

  5. Rename get to inner

    @van-sprundel
    van-sprundel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    86afd0a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into interface-newtypes

    @van-sprundel
    van-sprundel authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    55902f4 View commit details
    Browse the repository at this point in the history

  7. Fix branch rebase

    @van-sprundel
    van-sprundel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    552c440 View commit details
    Browse the repository at this point in the history