Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple more CI improvements #873

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Conversation

bjorn3
Copy link
Collaborator

@bjorn3 bjorn3 commented Oct 9, 2024

  • Give CI feedback for PR's against all branches, not just the main branch.
  • Let rustup pick the right nightly version instead of manually determining it.
  • Add back the problem matcher that CI improvements #870 removed.
  • Remove some unnecessary or counterproductive caching.

Continuation of #870.

This helps when opening a PR against another PR or against a long lived
branch.
Neither builds anything that can be cached.
No need to do it ourself. Also miri is now always available so we don't
need to look for the latest nightly with miri available.
This removes an external dependency that is currently looking for
maintainers and caching saves less than 10s in this case as the package
we install is only about 120kb.
This enables showing warnings and errors inline in the files tab of a PR.
@squell squell added the CI Meta-issues related to CI label Oct 9, 2024
@squell squell enabled auto-merge October 9, 2024 10:15
@squell squell requested a review from rnijveld October 9, 2024 13:38
@squell squell disabled auto-merge October 11, 2024 12:28
@squell squell enabled auto-merge (rebase) October 11, 2024 12:28
@squell squell merged commit 3b8ada2 into trifectatechfoundation:main Oct 11, 2024
12 checks passed
@bjorn3 bjorn3 deleted the ci_changes branch October 11, 2024 12:29
@squell squell added the minor minor issue, PR without an issue label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Meta-issues related to CI minor minor issue, PR without an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants