Safety comments: PR1 #860
Merged
Safety comments: PR1 #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
squell
commented
Sep 3, 2024
squell
force-pushed
the
safety-comments-1
branch
from
f4e6439
to
502fca4
Compare
rnijveld
reviewed
Sep 5, 2024
squell
force-pushed
the
safety-comments-1
branch
from
e569638
to
3baa697
Compare
squell
force-pushed
the
safety-comments-1
branch
from
3baa697
to
70e2a3a
Compare
pvdrz
previously requested changes
Sep 26, 2024
squell
force-pushed
the
safety-comments-1
branch
from
51ccb78
to
4c0a0ac
Compare
squell
force-pushed
the
safety-comments-1
branch
from
4c0a0ac
to
9027bb8
Compare
pvdrz
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's tedious to do, but let's have proper
# Safetyand// SAFETYcomments all across the board.This PR addresses some low-hanging fruit:
systempamandcutils.sys callwithlibc::close_range, since that is available now.This is related to #861 but does not close that issue. I've broken it up in multiple PR's for easier reviewing.