Support const blocks in const_continue #13
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
commented
Mar 25, 2025
bjorn3
commented
Mar 25, 2025
| self.tcx | ||
| .const_eval_resolve_for_typeck(self.typing_env(), uv, constant.span) | ||
| .unwrap() | ||
| .unwrap(), |
There was a problem hiding this comment.
These unwraps and !has_param assertions should also be errors.
bjorn3
force-pushed
the
loop_match_attr_consts
branch
from
b0fed64 to
af92d9d
Compare
|
This needs a test. |
bjorn3
force-pushed
the
loop_match_attr_consts
branch
from
337bf45 to
5a77008
Compare
bjorn3
commented
Mar 25, 2025
Comment on lines
769
to
786
| ConstOperand { | ||
| span: self.thir[value].span, | ||
| user_ty: None, | ||
| const_: Const::Ty( | ||
| self.thir[value].ty, | ||
| ty::Const::new_value( | ||
| self.tcx, | ||
| ValTree::from_branches( | ||
| self.tcx, | ||
| [ValTree::from_scalar_int( | ||
| self.tcx, | ||
| variant_index.as_u32().into(), | ||
| )], | ||
| ), | ||
| self.thir[value].ty, | ||
| ), | ||
| ), | ||
| } |
There was a problem hiding this comment.
Would be nice if this could reuse the logic in const eval.
folkertdev
force-pushed
the
loop_match_attr
branch
from
368f722 to
a89dcbe
Compare
|
btw do you really want to force the target to be a literal |
bjorn3
force-pushed
the
loop_match_attr_consts
branch
3 times, most recently
from
d372ec2 to
96c7b35
Compare
I prefer not changing the parser. That makes it less likely that |
bjorn3
force-pushed
the
loop_match_attr_consts
branch
4 times, most recently
from
b47c983 to
2fc8c4c
Compare
folkertdev
force-pushed
the
loop_match_attr
branch
from
f294773 to
6fe6909
Compare
Co-authored-by: Folkert de Vries <[email protected]>
Co-authored-by: Travis Cross <[email protected]>
folkertdev
force-pushed
the
loop_match_attr
branch
from
b3a87ed to
7d88da4
Compare
bjorn3
force-pushed
the
loop_match_attr_consts
branch
from
2fc8c4c to
7ff01ec
Compare
folkertdev
force-pushed
the
loop_match_attr
branch
from
516c380 to
2ea5bc8
Compare
folkertdev
force-pushed
the
loop_match_attr
branch
3 times, most recently
from
b2c9fe2 to
a774736
Compare
folkertdev
force-pushed
the
loop_match_attr
branch
3 times, most recently
from
0025cda to
ba5556d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.